Repository navigation
Conversation
PHP 8.6 deprecates spl_object_hash() in favor of spl_object_id(), which is available on all supported PHP versions. Cast the ID to string to preserve getResourceId()'s return type. Fixes bovigo#299
|
Just noticed this in one of my own projects that uses vfsStream in its unit tests. Thanks for starting a PR :) Hopefully the maintainer will have a chance to take a look. |
acoulton
added a commit
to acoulton/Gherkin
that referenced
this pull request
Nov 6, 2026
mikey179/vfstream triggers deprecations on PHP 8.6 due to use of `spl_object_hash`. Patch it on installation, using the fix proposed in bovigo/vfsStream#301.
acoulton
added a commit
to acoulton/Gherkin
that referenced
this pull request
Nov 6, 2026
mikey179/vfstream triggers deprecations on PHP 8.6 due to use of `spl_object_hash`. Patch it on installation, using the fix proposed in bovigo/vfsStream#301.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.6 deprecates spl_object_hash() in favor of spl_object_id(), which is available on all PHP versions supported by this branch. Cast the ID to string to preserve getResourceId()'s string return type.
Companion to #300, which targets the v1.6 release branch with a PHP 7.1 fallback.
Fixes #299